Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: throw unsupported warning when alter table with/without validation #16089

Merged

Conversation

cncal
Copy link
Contributor

@cncal cncal commented Apr 6, 2020

What problem does this PR solve?

Fix parser issue #606

What is changed and how it works?

mysql> use test
Database changed
mysql> create table t1 (c1 int, c2 int as (c1 + 1));
Query OK, 0 rows affected (0.03 sec)

mysql> alter table t1 with validation;
Query OK, 0 rows affected, 1 warning (0.00 sec)

mysql> show warnings;
+---------+------+------------------------------------------------------+
| Level   | Code | Message                                              |
+---------+------+------------------------------------------------------+
| Warning | 8200 | ALTER TABLE WITH VALIDATION is currently unsupported |
+---------+------+------------------------------------------------------+
1 row in set (0.00 sec)

mysql> alter table t1 without validation;
Query OK, 0 rows affected, 1 warning (0.00 sec)

mysql> show warnings;
+---------+------+---------------------------------------------------------+
| Level   | Code | Message                                                 |
+---------+------+---------------------------------------------------------+
| Warning | 8200 | ALTER TABLE WITHOUT VALIDATION is currently unsupported |
+---------+------+---------------------------------------------------------+
1 row in set (0.00 sec)

Check List

Tests

  • Unit test

Release note

  • No release note

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Apr 6, 2020
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Apr 6, 2020
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #16089 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16089   +/-   ##
===========================================
  Coverage   79.9969%   79.9969%           
===========================================
  Files           524        524           
  Lines        145408     145408           
===========================================
  Hits         116322     116322           
  Misses        19939      19939           
  Partials       9147       9147           

zimulala
zimulala previously approved these changes May 29, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cncal
Please fix the conflict and update the parser version in go.mod.

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

@cncal merge failed.

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

@sre-bot
Copy link
Contributor

sre-bot commented Jun 16, 2020

@cncal
Copy link
Contributor Author

cncal commented Jun 16, 2020

/rebuild

@cncal cncal requested review from zimulala and tangenta June 16, 2020 13:11
@cncal
Copy link
Contributor Author

cncal commented Jun 16, 2020

@zimulala @tangenta Conflicts resolved.

@tangenta
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@cncal merge failed.

@tangenta
Copy link
Contributor

/run-integration-br-test
/run-integration-common-test
/run-integration-copr-test

@tangenta
Copy link
Contributor

/run-integration-br-test

@zimulala zimulala merged commit 7f03358 into pingcap:master Jun 17, 2020
@cncal cncal deleted the warning_for_alter_table_with_validation branch July 10, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TiDB behavior: with validation
5 participants